feat: grow_heap host call #533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greywolve
force-pushed
the
feat/grow-heap-host-call
branch
from
9378126 to
72e1374
Compare
greywolve
force-pushed
the
feat/grow-heap-host-call
branch
from
72e1374 to
d045f9a
Compare
| // case 2: (▸, ϱ - g, max(a + c, φ₇), W) otherwise if φ₇ ≤ b ∧ ϱ ≥ g | ||
| if targetPage <= b && gas >= g { | ||
| if targetPage > currentPage { | ||
| mem.AllocatePages(currentPage, pagesToAllocate) |
Member
There was a problem hiding this comment.
I might be wrong, but I think we might not need to use this method, at least from the formula it looks like we are just growing the heap up to φ7 but without rounding it up to page size
Contributor
Author
There was a problem hiding this comment.
But allocate pages only operates on pages, it doesn't do any address -> page conversions, so there's no rounding up?
Contributor
Author
There was a problem hiding this comment.
But it might make sense to simplify it as growHeapTo(absolutePage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.