Rename module to keycloak_client_scope_mapping.#1
Open
odontomachus wants to merge 1 commit intoeikef:keycloak_scopefrom
Open
Rename module to keycloak_client_scope_mapping.#1odontomachus wants to merge 1 commit intoeikef:keycloak_scopefrom
odontomachus wants to merge 1 commit intoeikef:keycloak_scopefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Could this module be renamed to keycloak_client_scope_mapping?
As of Keycloak 4.0 there are "client scopes" at the realm level, with a top level menu entry for "client scope". This module manages the mapping of client scopes to clients (and client templates, although those are removed in KeyCloak >= 4.0 in favor of default default client scopes). I would like to add a module for these client scopes as keycloak_client_scope. Therefore, I think it would make sense to rename this module into keycloak_client_scope_mapping.
Aside from that, I have tested this module against Keycloak 4.8 & 6.0 (after having renamed the module) and I am looking forward to the module making it into Ansible.
See ansible#35558
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
keycloak_client_scope_mapping
ANSIBLE VERSION