Open
Conversation
This change reduces the Javascript footprint of react-masonry-component by switching to https://github.com/angus-c/just
Collaborator
|
hi @ksheedlo Thanks for this PR, just wondering how do you use this library i your project? We migrated over to the lodash library because most people these days if using React are using Webpack/Rollup with tree pruning so you wouldn't get all of the extra unused methods. Have you had any particular issues? |
Author
|
We are using browserify, but just should be lighter regardless of what bundler you are using. Here's a table of imported package weights sourced from bundlephobia.com
Just |
|
Waiting for this PR being accepted. We have lodash as peer dep in our projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces the Javascript footprint of react-masonry-component
by switching to https://github.com/angus-c/just