create const_cast.md // dynamic_cast.md#17
Open
SoWeBegin wants to merge 8 commits intoeisenwave:masterfrom
Open
create const_cast.md // dynamic_cast.md#17SoWeBegin wants to merge 8 commits intoeisenwave:masterfrom
SoWeBegin wants to merge 8 commits intoeisenwave:masterfrom
Conversation
SoWeBegin
changed the title
eisenwave
reviewed
Feb 9, 2022
| to undefined behavior, but also because it's very easy to break the constness-related best practices while using it. | ||
|
|
||
| ## Also See | ||
| To learn about all the rules related to const_cast, visit |
Owner
There was a problem hiding this comment.
Remove this sentence, it's redundant
|
|
||
|
|
||
| ## Also See | ||
| To learn about all the rules related to dynamic_cast, visit |
Owner
There was a problem hiding this comment.
Remove this sentence, it's redundant
| ``` | ||
|
|
||
| ## Notes | ||
| Downcasting can be applied through static_cast as well, but in that case no runtime check is performed. |
Owner
There was a problem hiding this comment.
Try to shorten the language in general, minimizing the word count. In this case "You can downcast with static_cast as well, but no runtime check is performed."
| if the conversion could not be applied. This also implies a little overhead when using this cast. | ||
|
|
||
| ## Useful conversions | ||
| dynamic_cast is mostly used when we need to downcast a base class to its derived class. |
| ## Examples | ||
| - Remove constness: | ||
| ```cpp | ||
| int main() { |
Owner
There was a problem hiding this comment.
Reduce LOC by removing int main(), we don't need a whole program to demonstrate how it works
|
|
||
| ## Also See | ||
| To learn about all the rules related to const_cast, visit | ||
| [cppreference: const_cast](https://en.cppreference.com/w/cpp/language/const_cast) |
Owner
There was a problem hiding this comment.
Add more links in both articles. Stackoverflow posts, CppCoreGuidelines recommendations for dynamic-cast and const-cast, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.