Fix various inconsistencies in OU implementation#6
Merged
Conversation
Critical: enforce m < p plaintext bound (not m < n); remove Ciphertext::Mul which was missing mod n reduction; fix stream format to preserve leading-zero bytes and distinguish empty from zero plaintext. Security: validate gcd(r,n)=1 for encryption nonce; privatize PrivateKey fields; replace safe prime generation with standard primes (not required by OU, 473x slower at 2048 bits); migrate decryption modpow to crypto-bigint BoxedMontyForm for constant-time exponentiation. Correctness: add gcd(g,n)=1 generator check; precompute l_gp_inv and p² in PrivateKey, eliminating runtime mod_inverse and repeated p² allocation; add Plaintext type with checked_add to surface homomorphic overflow. API: remove Ciphertext::Deref and unvalidated From<&[u8]>; replace glob re-exports with explicit items; cap untrusted block_count at 4M; extract parse_blocks(); make homomorphic_add_packed pub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical: enforce m < p plaintext bound (not m < n); remove Ciphertext::Mul which was missing mod n reduction; fix stream format to preserve leading-zero bytes and distinguish empty from zero plaintext.
Security: validate gcd(r,n)=1 for encryption nonce; privatize PrivateKey fields; replace safe prime generation with standard primes (not required by OU, 473x slower at 2048 bits); migrate decryption modpow to crypto-bigint BoxedMontyForm for constant-time exponentiation.
Correctness: add gcd(g,n)=1 generator check; precompute l_gp_inv and p² in PrivateKey, eliminating runtime mod_inverse and repeated p² allocation; add Plaintext type with checked_add to surface homomorphic overflow.
API: remove Ciphertext::Deref and unvalidated From<&[u8]>; replace glob re-exports with explicit items; cap untrusted block_count at 4M; extract parse_blocks(); make homomorphic_add_packed pub.