Adding penalization to identical contiguous voicing#10
Open
napulen wants to merge 1 commit intoekzhang:masterfrom
Open
Adding penalization to identical contiguous voicing#10napulen wants to merge 1 commit intoekzhang:masterfrom
napulen wants to merge 1 commit intoekzhang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dealing with #9.
Slight penalization on repeated voicings (
cost = 2).Tested with this example (a slight variation of the original example, 3 repeated harmonies):
Without penalization:

With penalization:

Notice that the third repeated pair,
VandV, was voiced identically (not always changing the voicing, which may be desired), but the first two changed.Second version sounds much better in my opinion.