Non blocking implementation#118
Open
YarekTyshchenko wants to merge 4 commits intoela-compil:masterfrom
Open
Conversation
YarekTyshchenko
force-pushed
the
non-blocking
branch
from
4e53227 to
774eb76
Compare
Using that interface prevents any meaningful refactoring towards task based system
ManualResetEvent blocks threads. Since network read operations can be done in a true non-blocking fashion, using MRE needlessly blocks threads.
YarekTyshchenko
force-pushed
the
non-blocking
branch
from
774eb76 to
1706ce6
Compare
YarekTyshchenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should partly address issues in #46 allowing the library to be used with concurrent queries, as long as
invokeIdissues are handled externallySome questions about the changes:
LastSegmentAck, but in my tests I haven't been able to trigger that codepathThe package is published temporarily here: https://www.nuget.org/packages/BACnet-fork-yarekt/