Open
Conversation
Member
|
@mRy0 Thanks for your contribution! Would it be possible that you open a pull request against v2 branch too? But first I can review this pull so we can merge it with master. |
gralin
requested changes
Jun 28, 2018
|
|
||
| public override string ToString() | ||
| { | ||
| return $"DaySchedule Len: {DaySchedule?.Count()}"; |
|
|
||
|
|
||
|
|
||
| public int Decode(byte[] buffer, int offset, uint count) |
Member
There was a problem hiding this comment.
Code cosmetics. Please remove extra new lines you added in some places like this, max one empty line is ok. And when you see a line wrapping here, then it means it's a bit too long, please try to make it shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote some code to get the weekly schedule working.
I added two classes BacnetDailySchedule struct with decode and encode and containing a List of BacnetTimeValue.
Reading and writing is testet against different ela certified PLCs.