feat(dr): Add cascading includes support to dependency.lic#7293
Merged
MahtraDR merged 2 commits intoelanthia-online:mainfrom Feb 9, 2026
Merged
feat(dr): Add cascading includes support to dependency.lic#7293MahtraDR merged 2 commits intoelanthia-online:mainfrom
MahtraDR merged 2 commits intoelanthia-online:mainfrom
Conversation
Add support for nested includes in YAML configuration files. Include files can now have their own `include:` property that references other include files, enabling modular and hierarchical configurations. Changes: - Add `resolve_includes_recursively` method for depth-first resolution - Modify `get_settings` to use recursive include resolution - Add circular dependency protection via Set-based visited tracking - Handle diamond dependencies (shared includes loaded once) - Add debug output for resolved include order - Version bump: 2.0.21 -> 2.1.0 Backwards compatible - existing single-level includes work unchanged. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 4c79f71 in 9 seconds. Click for details.
- Reviewed
507lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_Pp9yqzJCiBFkkY1l
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
- Move IncludeResolver class outside RSpec block (Lint/ConstantDefinitionInBlock) - Fix indentation issues in dependency.lic - Remove redundant require 'set' (built-in in Ruby 4.0) - Fix hash alignment and extra spacing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for cascading includes in YAML configuration files. Include files can now have their own
include:property that references other include files, enabling modular and hierarchical configurations.Version:
2.0.21→2.1.0Changes
resolve_includes_recursivelymethod for depth-first include resolutionget_settingsto use recursive include resolutionSet-based visited trackingProblem
Previously,
include:only worked at a single level. IfMahtra-setup.yamlincludedinclude-hunting.yaml, that hunting file could NOT itself include other files. Players had to list ALL dependencies in their character file.Solution
Include files can now nest includes:
Merge Order (Depth-First)
Edge Cases Handled
a -> b -> a- Uses visited Set, no infinite loopsBackwards Compatibility
Fully backwards compatible - existing configurations work unchanged.
Test Plan
🤖 Generated with Claude Code
Important
Adds cascading includes support to YAML configuration files in
dependency.lic, with depth-first resolution and circular dependency protection, and introduces 18 new spec tests.dependency.lic.resolve_includes_recursivelyfor depth-first include resolution.get_settingsto use recursive include resolution.Set-based visited tracking.dependency_cascading_includes_spec.rbcovering edge cases like circular dependencies, diamond dependencies, missing files, and self-references.2.0.21to2.1.0.This description was created by
for 4c79f71. You can customize this summary. It will automatically update as commits are pushed.