feat(dr): Add bonus scroll drop chance to knackstone preferences

[MahtraDR]

Summary

• Add "bonus scroll drop chance" to the DEFAULT_PREFERENCES list in knackstone.lic
• Create comprehensive spec file with 85 tests

Changes

• knackstone.lic: Added new preference option for scroll drop chance bonus
• spec/knackstone_spec.rb: New spec file covering:
  • All public and private methods
  • Initialization with various settings combinations
  • Container vs worn knackstone modes
  • Edge cases and error handling
  • Integration scenarios for full voting flow

Test plan

• All 85 specs pass locally
• Rubocop passes with no offenses
• CI passes

🤖 Generated with Claude Code

Important

Added comprehensive RSpec test suite for the Knackstone class and updated the bonus descriptions list to include a new "bonus scroll drop chance" option.

• Knackstone Class Tests:
  • Added 948 lines of comprehensive RSpec test suite in spec/knackstone_spec.rb covering all public and private methods.
  • Includes test harness setup with mock game objects and modules (DRC, DRCI, Lich::Util).
  • Tests for DEFAULT_PREFERENCES constant verifying 12 bonus options and frozen state.
  • Tests for three regex constants (BONUS_OPTIONS_REGEX, ALREADY_USED_REGEX, CONFIRMATION_REGEX) with pattern matching validation.
  • Tests for #initialize method covering default and custom preferences, noun, container, worn state, and debug settings.
  • Tests for #run method with separate contexts for unusable state, container mode, and worn mode.
  • Tests for private methods including #debug?, #unusable_state?, #remove_worn_knackstone, #wear_knackstone, #put_away_knackstone, #ensure_knackstone_in_hand, #use_knackstone, #find_best_option, #vote_for, and #whisper_command.
  • Tests for #find_best_option covering preference ordering, unknown options, and debug output.
  • Tests for #vote_for covering choice number calculation, confirmation handling, and custom noun usage.
  • Integration tests for full voting flow with both container and worn knackstone modes.
  • Source code invariant tests verifying frozen string literal pragma, frozen constants, and expected content.
• Knackstone Class Updates:
  • Added "bonus scroll drop chance" to the bonus descriptions list in knackstone.lic.

^{This description was created by for 87839b5. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 87839b5 in 8 seconds. Click for details.

• Reviewed 966 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 0 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_yik38vs6C9K3qtTG

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}