Skip to content

Conversation

@mrhoribu
Copy link
Contributor

@mrhoribu mrhoribu commented Jan 28, 2026

  • replaced overflow_container and secondary_overflow with single overflow_containers setting (comma-separated)
  • added configurable "Trash to Dump" section, instead of hardcoded herb/food/junk

Important

This PR updates eloot.lic to use a single overflow container setting, adds configurable trash dumping, and includes various bug fixes and migrations.

  • Behavior:
    • Replaces overflow_container and secondary_overflow with overflow_containers (comma-separated) in eloot.lic.
    • Adds trash_dump_types setting for configurable trash dumping, replacing hardcoded values.
    • Allows custom bank withdraw amount for locksmithing.
  • Bug Fixes:
    • Fixes erroneous commas in script parameters.
    • Fixes box storage in non-group disk and locked box message.
    • Fixes single_drag_box cycling through all group disks when use_disk_group is false.
    • Fixes eonake gauntlet XML matching and in-region check.
  • Migration:
    • Adds migrate_overflow_settings() to convert old overflow settings to new format.
  • UI and Inventory:
    • Updates UI to reflect new overflow container settings.
    • Dynamically handles overflow containers in inventory methods.

This description was created by Ellipsis for 8cd39f0. You can customize this summary. It will automatically update as commits are pushed.

    - replaced overflow_container and secondary_overflow with single overflow_containers setting (comma-separated)
    - added configurable "Trash to Dump" section, instead of hardcoded herb/food/junk
ellipsis-dev[bot]

This comment was marked as outdated.

@Deysh
Copy link
Contributor

Deysh commented Jan 28, 2026

Probably want to remove food, herb, and junk toggles in the sell type section since they are covered by the trash to dump section.

@mrhoribu
Copy link
Contributor Author

Probably want to remove food, herb, and junk toggles in the sell type section since they are covered by the trash to dump section.

I kept old functionality that it still checks the "sell" types in order to then trash/junk stuff. So you have to have both checked in order to actually dump. Couldn't think of a better way to safeguard. That way it tries to sell first any category and then dumps (just for food/herbs/junk it can't really sell, but still needed to be checked)

@mrhoribu mrhoribu marked this pull request as draft January 31, 2026 16:56
@mrhoribu mrhoribu marked this pull request as ready for review January 31, 2026 16:56
ellipsis-dev[bot]

This comment was marked as outdated.

force saving of migrated settings for overflow upon migration
@mrhoribu mrhoribu marked this pull request as draft February 1, 2026 01:11
@mrhoribu mrhoribu marked this pull request as ready for review February 1, 2026 01:11
ellipsis-dev[bot]

This comment was marked as outdated.

@Deysh Deysh mentioned this pull request Feb 1, 2026
@mrhoribu mrhoribu marked this pull request as draft February 7, 2026 16:27
@mrhoribu mrhoribu marked this pull request as ready for review February 7, 2026 16:27
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 8cd39f0 in 11 seconds. Click for details.
  • Reviewed 513 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_98ATe1Fw9ycThSbA

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants