-
Notifications
You must be signed in to change notification settings - Fork 54
fix(eloot.lic): v2.7.1 multiple fixes #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- replaced overflow_container and secondary_overflow with single overflow_containers setting (comma-separated)
- added configurable "Trash to Dump" section, instead of hardcoded herb/food/junk
|
Probably want to remove food, herb, and junk toggles in the sell type section since they are covered by the trash to dump section. |
I kept old functionality that it still checks the "sell" types in order to then trash/junk stuff. So you have to have both checked in order to actually dump. Couldn't think of a better way to safeguard. That way it tries to sell first any category and then dumps (just for food/herbs/junk it can't really sell, but still needed to be checked) |
force saving of migrated settings for overflow upon migration
Updated the total tips calculation to include a custom withdraw amount setting for the locksmith.
Refactor in_region method to improve boundary check logic and add a bugfix for destination room check.
Add comment to clarify bounty town region check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 8cd39f0 in 11 seconds. Click for details.
- Reviewed
513lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_98ATe1Fw9ycThSbA
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Important
This PR updates
eloot.licto use a single overflow container setting, adds configurable trash dumping, and includes various bug fixes and migrations.overflow_containerandsecondary_overflowwithoverflow_containers(comma-separated) ineloot.lic.trash_dump_typessetting for configurable trash dumping, replacing hardcoded values.single_drag_boxcycling through all group disks whenuse_disk_groupis false.migrate_overflow_settings()to convert old overflow settings to new format.This description was created by
for 8cd39f0. You can customize this summary. It will automatically update as commits are pushed.