Skip to content

update gosigar to v0.14.4#49553

Merged
leehinman merged 3 commits intoelastic:mainfrom
leehinman:update_gosigar
Mar 24, 2026
Merged

update gosigar to v0.14.4#49553
leehinman merged 3 commits intoelastic:mainfrom
leehinman:update_gosigar

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

Proposed commit message

update github/elastic/gosigar to v0.14.4

This is done specifically to bring in elastic/gosigar#190, which will allow the filesystem metricset of the metricbeat system module to skip over volumes that don't exist on Windows. Examples would be transient, ejected or ghost volumes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Should provide more robust collection of filesystem metrics on Windows systems.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 18, 2026

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@leehinman leehinman added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.19 Automated backport to the 8.19 branch backport-9.2 Automated backport to the 9.2 branch backport-9.3 Automated backport to the 9.3 branch labels Mar 18, 2026
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2026
@leehinman leehinman marked this pull request as ready for review March 18, 2026 21:33
@leehinman leehinman requested a review from a team as a code owner March 18, 2026 21:33
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Comment thread changelog/fragments/1773868374-update-gosigar-to-v0.14.4.yaml Outdated
Comment thread changelog/fragments/1773868374-update-gosigar-to-v0.14.4.yaml Outdated
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d72d2656-7755-4ad0-90df-1055d24a72ef

📥 Commits

Reviewing files that changed from the base of the PR and between 80acd26 and 844815c.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • NOTICE.txt
  • changelog/fragments/1773868374-update-gosigar-to-v0.14.4.yaml
  • go.mod
✅ Files skipped from review due to trivial changes (3)
  • go.mod
  • changelog/fragments/1773868374-update-gosigar-to-v0.14.4.yaml
  • NOTICE.txt

📝 Walkthrough

Walkthrough

This pull request updates the github.com/elastic/gosigar dependency from v0.14.3 to v0.14.4. Changes: go.mod version bump, NOTICE.txt license reference changed to the v0.14.4 path, and a new changelog fragment describing a bug-fix for metricbeat on Windows where filesystem metrics could error for removed volumes.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 22, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update_gosigar upstream/update_gosigar
git merge upstream/main
git push upstream update_gosigar

leehinman and others added 3 commits March 23, 2026 13:43
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
@leehinman leehinman merged commit b49ecb8 into elastic:main Mar 24, 2026
206 checks passed
mergify Bot pushed a commit that referenced this pull request Mar 24, 2026
* update gosigar to v0.14.4

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit b49ecb8)

# Conflicts:
#	go.mod
#	go.sum
mergify Bot pushed a commit that referenced this pull request Mar 24, 2026
* update gosigar to v0.14.4

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit b49ecb8)

# Conflicts:
#	go.sum
mergify Bot pushed a commit that referenced this pull request Mar 24, 2026
* update gosigar to v0.14.4

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit b49ecb8)
@github-actions github-actions Bot mentioned this pull request Mar 24, 2026
leehinman pushed a commit that referenced this pull request Mar 24, 2026
* update gosigar to v0.14.4 (#49553)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit b49ecb8)
leehinman added a commit that referenced this pull request Mar 24, 2026
* update gosigar to v0.14.4


(cherry picked from commit b49ecb8)

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
leehinman pushed a commit that referenced this pull request Mar 25, 2026
* update gosigar to v0.14.4 (#49553)


Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit b49ecb8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.2 Automated backport to the 9.2 branch backport-9.3 Automated backport to the 9.3 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants