Restructure doc and add inline examples #1793
Open
+269
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
…der into update-applies-to-docs
|
@colleenmcginnis Thanks! Changes applied. |
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Comment on lines
+87
to
+93
| A specialized `{preview}` role exists to quickly mark something as a technical preview. It takes a required version number | ||
| as an argument. | ||
|
|
||
| ```markdown | ||
| Property {preview}`<version>` | ||
| : definition body | ||
| ``` |
There was a problem hiding this comment.
I like the shortened syntax but I'm wondering if we really want to encourage badges without product keys at this point. I see the benefit, I'm just concerned about output consistency
There was a problem hiding this comment.
This was in the original version. I'm OK with removing it.
There was a problem hiding this comment.
@colleenmcginnis WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1789