Skip to content

Fixes #63 - Breadcrumbs issue in new docs pages #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #63 - Breadcrumbs issue in new docs pages #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions docs/_docset.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,19 @@ toc:
- folder: baz
children:
- file: qux.md
- folder: breadcrumbs
children:
- file: index.md
- file: level-2.md
- folder: level-3
children:
- file: index.md
- file: level-3.md
- folder: level-4
children:
- file: index.md
- file: level-4.md
- folder: level-5
children:
- file: index.md
- file: level-5.md
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Breadcrumbs
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/level-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Level-2 File
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/level-3/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Level-3
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/level-3/level-3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Level-3 File
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/level-3/level-4/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Level-4
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/level-3/level-4/level-4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Level-4 File
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/level-3/level-4/level-5/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Level-5
1 change: 1 addition & 0 deletions docs/testing/breadcrumbs/level-3/level-4/level-5/level-5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Level-5 File
2 changes: 1 addition & 1 deletion src/Elastic.Markdown/Layout/_Breadcrumbs.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<meta itemprop="position" content="@(i+2)">
</li>
}
<li class="inline text-ink-light text-sm leading-[1.2em]" itemprop="itemListElement" itemscope="" itemtype="https://schema.org/ListItem">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to keep the item* attributes and add position as well.

<li class="inline text-ink-light text-sm leading-[1.2em]">
<span class="px-1">/</span>
</li>
</ol>
Loading