-
Notifications
You must be signed in to change notification settings - Fork 450
[RFC 0052] Stage 2: Update additional GenAI fields #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2532/reference/ |
🔍 Preview links for changed docs |
8ece5e6
to
9b177e4
Compare
| [ECS](/reference/ecs-ecs.md) | Meta-information specific to ECS. | | ||
| [ELF Header](/reference/ecs-elf.md) | These fields contain Linux Executable Linkable Format (ELF) metadata. | | ||
| [Email](/reference/ecs-email.md) | Describes an email transaction. | | ||
| [Entity](/reference/ecs-entity.md) | Fields to describe various types of entities across IT environments. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased off main and then generated the files, not sure why these changes are still showing up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was bug unrelated to this in how the entity fields are generated. The fix for that isn't merged yet.
Don't worry about these changes in your PR for now, it'll go away once the other fix is merged.
1b04b05
to
22cdf78
Compare
Looking for feedback
For most of the fields, they are lists of .json objects, or .json objects. For fields whose content could be very long (
input.messages
,output.messages
), I have proposed that they are theflattened
type due to costs.via docs for
nested
type:Though as I am not a subject matter expert on the field types and efficiency, looking for additional feedback or comments.
1. What does this PR do?
2. Which ECS fields are affected/introduced?
Changes based on OTel https://github.com/open-telemetry/semantic-conventions/pull/2179/files
3. Why is this change necessary?
4. Have you added/updated documentation?
YES / NO / N/A
5. Have you built ECS and committed any newly generated files?
YES / NO
6. Have you run the ECS validation tests locally?
YES / NO
7. Anything else for the reviewers?
Commit Message