Change entity multi_field text type to match_only_text #2547
+100
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the field type for multi_field values in entity from text to match_only_text. This change will match the multi_field type used for other similar fields in other schema files, and will match the expected dynamic value in ecs@mappings.
|
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2547/reference/ |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
flash1293
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
LGTM, this looks like it would fix the problem explained here: https://buildkite.com/elastic/elasticsearch-ecs-dynamic-templates-tests/builds/766#0199b51a-cf46-46fa-a72a-f589ff822206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR do?
Change the multi_field field type in the entity schema to
match_only_text.2. Which ECS fields are affected/introduced?
entity.nameandentity.display_name, and the other fieldsets where entity is re-used are affected.3. Why is this change necessary?
match_only_textis the dynamic mapping type that matches these fields, and is what is used for other similar fields, so changing the type will make this consistent with others.4. Have you added/updated documentation?
YES
5. Have you built ECS and committed any newly generated files?
YES
6. Have you run the ECS validation tests locally?
YES
7. Anything else for the reviewers?
Commit Message
Change the field type for multi_field values in entity from text to match_only_text.
This change will match the multi_field type used for other similar fields in other schema files, and will match the expected dynamic value in ecs@mappings.