Specification fixes #5472
Merged
Specification fixes #5472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It got removed in 2019 in Elasticsearch 7.5.
They are the default values used in the Operator enum.
pquentin
commented
Oct 10, 2025
Comment on lines
-117
to
-120
| /** | ||
| * This option is deprecated because it can cause primary and replica shards to diverge. | ||
| */ | ||
| force |
There was a problem hiding this comment.
pquentin
commented
Oct 10, 2025
| * @server_default 30s | ||
| */ | ||
| master_timeout?: TimeUnit | ||
| master_timeout?: Duration |
There was a problem hiding this comment.
Every single master_timeout uses Duration, except this one.
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
l-trotta
approved these changes
Oct 13, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5472-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c59570341f6984f98e056f0a6df367729d57d85d
# Push it to GitHub
git push --set-upstream origin backport-5472-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
* Remove VersionType.force It got removed in 2019 in Elasticsearch 7.5. * Switch to lowercase default_operator They are the default values used in the Operator enum. * Fix streams.status master_timeout * Run make contrib (cherry picked from commit c595703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on generating the rest-api-spec, I'm seeing various things to fix.
Each commit has an explanation for the change.