Skip to content

[EMS] Add Morocco prefectures & provinces layer#647

Merged
jsanz merged 9 commits intoelastic:feature-layersfrom
nelmalki:feature-layers
May 4, 2026
Merged

[EMS] Add Morocco prefectures & provinces layer#647
jsanz merged 9 commits intoelastic:feature-layersfrom
nelmalki:feature-layers

Conversation

@nelmalki
Copy link
Copy Markdown
Contributor

Adds a GeoJSON layer for Morocco’s 75 prefectures and provinces:

  • Cleaned OSM boundaries (removed non-admin features, deduplicated)
  • Validated against ISO3166-2 / Wikidata
  • Standardized fields: id, label_fr, label_ar, label_en, iso_3166_2

@prodsecmachine
Copy link
Copy Markdown

prodsecmachine commented Apr 24, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@jsanz jsanz self-requested a review April 24, 2026 15:34
@jsanz jsanz added enhancement New feature or request data Data related issues and requests labels Apr 24, 2026
@jsanz
Copy link
Copy Markdown
Contributor

jsanz commented Apr 24, 2026

Thanks for the contribution @nelmalki, we'll look into this next week

@jsanz
Copy link
Copy Markdown
Contributor

jsanz commented Apr 28, 2026

@nelmalki are you finished with your fixes? Can I plan for reviewing this?

@jsanz jsanz changed the title Add Morocco prefectures & provinces layer [EMS] Add Morocco prefectures & provinces layer Apr 28, 2026
@jsanz jsanz self-assigned this Apr 28, 2026
@nelmalki
Copy link
Copy Markdown
Contributor Author

@nelmalki are you finished with your fixes? Can I plan for reviewing this?

@jsanz yep all good to go 🚢

Copy link
Copy Markdown
Contributor

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelmalki thanks again for your contribution, I've added a few comments for clarification. Also, these two other comments for you to take a look, purely cosmetic

  • Inconsistent trailing commas in HJSON (e.g. versions: '>=1',, wikidata: Q6360877,, fieldMapping: [...], have commas; others don't). Other files in the repo are consistent, no commas throughout.
  • Inner SPARQL variable named ?id1 instead of ?id, all other files in the repo use ?id/?id2. Cosmetic but worth aligning.

Comment thread sources/ma/morocco_prefectures_provinces_v1.hjson Outdated
Comment thread sources/ma/morocco_prefectures_provinces_v1.hjson Outdated
Comment thread sources/ma/morocco-prefectures-provinces-v1.hjson
Comment thread sources/ma/morocco_prefectures_provinces_v1.hjson Outdated
Copy link
Copy Markdown
Contributor

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelmalki thanks for addressing the feedback. I agree on renaming the regions source file to be consistent with the new prefectures & provinces dataset. One last change, can you remove the regions dataset from the PR? The file is just formatted differently and unrelated to this PR. Thanks!

@nelmalki
Copy link
Copy Markdown
Contributor Author

@nelmalki thanks for addressing the feedback. I agree on renaming the regions source file to be consistent with the new prefectures & provinces dataset. One last change, can you remove the regions dataset from the PR? The file is just formatted differently and unrelated to this PR. Thanks!

of course, should be good now

@nelmalki nelmalki requested a review from jsanz April 30, 2026 20:12
@jsanz jsanz merged commit 8f71b5c into elastic:feature-layers May 4, 2026
3 checks passed
@jsanz
Copy link
Copy Markdown
Contributor

jsanz commented May 7, 2026

@nelmalki we've just pushed to production the new dataset and should be available on your environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Data related issues and requests enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants