[EMS] Add Morocco prefectures & provinces layer#647
[EMS] Add Morocco prefectures & provinces layer#647jsanz merged 9 commits intoelastic:feature-layersfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Thanks for the contribution @nelmalki, we'll look into this next week |
|
@nelmalki are you finished with your fixes? Can I plan for reviewing this? |
jsanz
left a comment
There was a problem hiding this comment.
@nelmalki thanks again for your contribution, I've added a few comments for clarification. Also, these two other comments for you to take a look, purely cosmetic
- Inconsistent trailing commas in HJSON (e.g.
versions: '>=1',,wikidata: Q6360877,,fieldMapping: [...],have commas; others don't). Other files in the repo are consistent, no commas throughout. - Inner SPARQL variable named
?id1instead of?id, all other files in the repo use?id/?id2. Cosmetic but worth aligning.
Co-authored-by: Jorge Sanz <jorge@jorgesanz.net>
jsanz
left a comment
There was a problem hiding this comment.
@nelmalki thanks for addressing the feedback. I agree on renaming the regions source file to be consistent with the new prefectures & provinces dataset. One last change, can you remove the regions dataset from the PR? The file is just formatted differently and unrelated to this PR. Thanks!
of course, should be good now |
|
@nelmalki we've just pushed to production the new dataset and should be available on your environments. |
Adds a GeoJSON layer for Morocco’s 75 prefectures and provinces: