Replace deprecated pathutils.rmtree by FileUtils.remove_dir #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
nklkarthi
reviewed
May 4, 2025
nklkarthi
left a comment
nklkarthi
left a comment
There was a problem hiding this comment.
# Move config files into etc
(etc/"elasticsearch").install Dir[libexec/"config/*"]
FileUtils.rm_r(libexec/"config")
This worked for me
Author
Thanks @nklkarthi . Not so familiar with Ruby, there seem to be many different ways to delete a directory. The current code with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing elasticsearch-full fails with a MethodDeprecatedError. Replace pathutils.rmtree by fileutils.remove_dir.
Fixes #173