-
Notifications
You must be signed in to change notification settings - Fork 483
[Cloud Security] Add Cloud Connectors credential option for Cloud Asset Inventory and CSPM for Azure #15237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Cloud Connectors as a credential option for the Azure provider in the Cloud Asset Inventory integration. This enhancement allows users to configure Azure asset discovery using Cloud Connectors authentication alongside existing methods like Service Principal and Managed Identity.
- Add "Cloud Connectors" as a new credential type option in the Azure configuration
- Include required input variables and configuration template for Cloud Connectors authentication
- Update package version to 1.1.1-preview to reflect the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/cloud_asset_inventory/manifest.yml |
Bumps package version to 1.1.1-preview |
packages/cloud_asset_inventory/data_stream/asset_inventory/manifest.yml |
Adds Cloud Connectors credential type, input variables, and configuration template for Azure |
packages/cloud_asset_inventory/changelog.yml |
Documents the enhancement in the changelog |
Comments suppressed due to low confidence (1)
packages/cloud_asset_inventory/data_stream/asset_inventory/manifest.yml:1
- The description should be updated to include Cloud Connectors since the Client ID field is now also required for the new Cloud Connectors credential type.
title: Cloud Assets Discovery
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e47d0c8
to
508ef90
Compare
35adef8
to
cf95e59
Compare
81f7af5
to
2725fbf
Compare
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
findings |
55555.56 | 40000 | -15555.56 (-28%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
cc @seanrathier |
|
Package cloud_asset_inventory - 1.1.3 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/1.1.3/ |
@@ -1,7 +1,7 @@ | |||
format_version: 3.3.2 | |||
name: cloud_asset_inventory | |||
title: "Cloud Asset Discovery" | |||
version: "1.1.1-preview01" | |||
version: "1.1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it been 1.1.1-preview02? to follow the same CSP strategy of bumping the version only after Feature Freeze.
The reason we follow the process is that since we have a custom UI, some of the times the integration will rely on Kibana to be updated in order to work properly with the updated integration, then for those cases then we need to wait for Kibana to be released in Serverless before making it available.
Proposed commit message
Checklist
changelog.yml
file.How to test this PR locally
elastic-package
1.1.1-preview
in the URLRelated issues
Screenshots