Skip to content

Conversation

seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Sep 8, 2025

Proposed commit message

  • Adds Cloud Connector credential type for Cloud Asset Inventory Azure input type.
  • Adds Cloud Connector credential type for CSPM Azure input type.
  • Changed Azure client-id and tenant-id to be secret.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Pull this branch locally
  • Build using elastic-package
  • Deploy the package to ESS or Serverless
  • Navigate to Cloud Asset Discovery integration with the version 1.1.1-preview in the URL
  • Select Azure provider
  • The Cloud Connector option should be a credential type

Related issues

Screenshots

Screenshot 2025-09-08 at 5 26 02 PM

@seanrathier seanrathier self-assigned this Sep 8, 2025
@seanrathier seanrathier added the enhancement New feature or request label Sep 8, 2025
@seanrathier seanrathier requested a review from a team as a code owner September 8, 2025 21:27
@andrewkroh andrewkroh added Integration:cloud_asset_inventory Cloud Asset Discovery Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Sep 9, 2025
@seanrathier seanrathier requested a review from Copilot September 9, 2025 14:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Cloud Connectors as a credential option for the Azure provider in the Cloud Asset Inventory integration. This enhancement allows users to configure Azure asset discovery using Cloud Connectors authentication alongside existing methods like Service Principal and Managed Identity.

  • Add "Cloud Connectors" as a new credential type option in the Azure configuration
  • Include required input variables and configuration template for Cloud Connectors authentication
  • Update package version to 1.1.1-preview to reflect the new functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/cloud_asset_inventory/manifest.yml Bumps package version to 1.1.1-preview
packages/cloud_asset_inventory/data_stream/asset_inventory/manifest.yml Adds Cloud Connectors credential type, input variables, and configuration template for Azure
packages/cloud_asset_inventory/changelog.yml Documents the enhancement in the changelog
Comments suppressed due to low confidence (1)

packages/cloud_asset_inventory/data_stream/asset_inventory/manifest.yml:1

  • The description should be updated to include Cloud Connectors since the Client ID field is now also required for the new Cloud Connectors credential type.
title: Cloud Assets Discovery

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@seanrathier seanrathier force-pushed the cloud-connector-azure branch from e47d0c8 to 508ef90 Compare September 9, 2025 14:20
@elastic elastic deleted a comment from Copilot AI Sep 9, 2025
@seanrathier seanrathier enabled auto-merge (squash) September 9, 2025 14:22
@seanrathier seanrathier disabled auto-merge September 9, 2025 17:46
@seanrathier seanrathier changed the title [Cloud Security] Add Cloud Connectors credential option for Cloud Asset Inventory Azure [Cloud Security] Add Cloud Connectors credential option for Cloud Asset Inventory and CSPM for Azure Sep 9, 2025
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Sep 10, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package cloud_security_posture 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
findings 55555.56 40000 -15555.56 (-28%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @seanrathier

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@seanrathier seanrathier merged commit 744672e into elastic:main Sep 10, 2025
8 of 9 checks passed
@elastic-vault-github-plugin-prod

Package cloud_asset_inventory - 1.1.3 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/1.1.3/

@@ -1,7 +1,7 @@
format_version: 3.3.2
name: cloud_asset_inventory
title: "Cloud Asset Discovery"
version: "1.1.1-preview01"
version: "1.1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it been 1.1.1-preview02? to follow the same CSP strategy of bumping the version only after Feature Freeze.

The reason we follow the process is that since we have a custom UI, some of the times the integration will rely on Kibana to be updated in order to work properly with the updated integration, then for those cases then we need to wait for Kibana to be released in Serverless before making it available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cloud_asset_inventory Cloud Asset Discovery Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants