[Entity Store] Publish v2 API routes#260396
Conversation
|
|
||
| const extractionResponse = await apiClient.post( | ||
| ENTITY_STORE_ROUTES.FORCE_LOG_EXTRACTION('user'), | ||
| ENTITY_STORE_ROUTES.internal.FORCE_LOG_EXTRACTION('user'), |
There was a problem hiding this comment.
Just want to double check the internal headers here was meant since everywhere else seems to be going from internal -> public. Is this a logs extraction specific perms elevation needed or something similar?
There was a problem hiding this comment.
This was very much deliberate. The difference between public and internal is not very heavily gated, but endpoints like FORCE_LOG_EXTRACTION were not meant for "public" use - either by other plugins or the end users.
x-pack/solutions/security/plugins/entity_store/test/scout/api/tests/history_snapshot.spec.ts
Show resolved
Hide resolved
CAWilson94
left a comment
There was a problem hiding this comment.
LGTM 🚀 asked one non blocking question 🙏
|
Warning Do not merge before #259732 |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @kubasobon |
Summary
Towards #248279
Design outline and breaking change proposal: https://github.com/elastic/dev/issues/3455 (accepted)
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.