Skip to content

[Entity Store] Publish v2 API routes#260396

Merged
kubasobon merged 13 commits intomainfrom
entity-store-v2-publish-api
Apr 3, 2026
Merged

[Entity Store] Publish v2 API routes#260396
kubasobon merged 13 commits intomainfrom
entity-store-v2-publish-api

Conversation

@kubasobon
Copy link
Copy Markdown
Member

@kubasobon kubasobon commented Mar 31, 2026

Summary

Towards #248279
Design outline and breaking change proposal: https://github.com/elastic/dev/issues/3455 (accepted)

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@kubasobon kubasobon self-assigned this Mar 31, 2026
@kubasobon kubasobon added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 31, 2026
@uri-weisman uri-weisman requested a review from chennn1990 March 31, 2026 10:39
@kubasobon kubasobon marked this pull request as ready for review March 31, 2026 10:39
@kubasobon kubasobon requested a review from a team as a code owner March 31, 2026 10:39
@kubasobon kubasobon requested a review from a team as a code owner March 31, 2026 14:19
@kubasobon kubasobon requested a review from CAWilson94 March 31, 2026 14:19

const extractionResponse = await apiClient.post(
ENTITY_STORE_ROUTES.FORCE_LOG_EXTRACTION('user'),
ENTITY_STORE_ROUTES.internal.FORCE_LOG_EXTRACTION('user'),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to double check the internal headers here was meant since everywhere else seems to be going from internal -> public. Is this a logs extraction specific perms elevation needed or something similar?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very much deliberate. The difference between public and internal is not very heavily gated, but endpoints like FORCE_LOG_EXTRACTION were not meant for "public" use - either by other plugins or the end users.

Copy link
Copy Markdown
Contributor

@CAWilson94 CAWilson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 asked one non blocking question 🙏

@kubasobon kubasobon requested a review from a team as a code owner April 2, 2026 09:37
@kubasobon
Copy link
Copy Markdown
Member Author

Warning

Do not merge before #259732

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / should call onSelectionChange on user selection
  • [job] [logs] FTR Configs #52 / Entity Analytics - Risk Score Maintainer @ess @serverless @serverlessQA Risk Score Maintainer Resolution Scoring with test log data aggregates a multi-alias group into a single resolution score
  • [job] [logs] FTR Configs #36 / ESQL execution logic API @ess @serverless ES|QL rule type esql query specific syntax mv_expand command pagination should not create more than max_signals alerts from single document when paginate through results
  • [job] [logs] Jest Integration Tests #10 / workflow with wait step when duration is short should have correct workflow duration

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.6MB 11.6MB +94.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
entityStore 8.4KB 8.5KB +124.0B

History

cc @kubasobon

@kubasobon kubasobon merged commit cdedd22 into main Apr 3, 2026
21 checks passed
@kubasobon kubasobon deleted the entity-store-v2-publish-api branch April 3, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants