-
Notifications
You must be signed in to change notification settings - Fork 16
fix(org-data): skip prompts when CLI options are provided, fix entity store correlations #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,17 +20,26 @@ export const orgDataCommands: CommandModule = { | |
| ) | ||
| .option('--all', 'Generate all integrations regardless of company size') | ||
| .option('--detection-rules', 'Include sample detection rules for applicable integrations') | ||
| .option( | ||
| '--size <size>', | ||
| 'Organization size without prompting (john-doe|small|medium|enterprise)', | ||
| ) | ||
|
Comment on lines
+23
to
+26
|
||
| .option( | ||
| '--productivity-suite <suite>', | ||
| 'Productivity suite without prompting (microsoft|google)', | ||
| ) | ||
| .addHelpText('after', '\n' + getOrgDataHelp()) | ||
| .action( | ||
| wrapAction(async (options) => { | ||
| await runOrgData({ | ||
| size: 'medium', | ||
| size: options.size, | ||
| name: options.name, | ||
| space: options.space, | ||
| seed: options.seed, | ||
| integrations: options.integrations, | ||
| all: options.all, | ||
| detectionRules: options.detectionRules, | ||
| productivitySuite: options.productivitySuite, | ||
| }); | ||
| }), | ||
| ); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README documents
--sizevalues asjohn-doe, but the implementation usesjohn_doe(underscore). Using the documented value will lead to an invalid size and can break generation (e.g. size-based config lookups). Update the docs to match the actual accepted value, or implement an alias mapping in the CLI.