Skip to content

Fix missing appender error #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pickypg merged 2 commits into from
Oct 22, 2025
Merged

Fix missing appender error #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbdfd0d
Fix missing appender error
fdartayre Oct 21, 2025
512ae7c
Close logs
fdartayre Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/co/elastic/support/BaseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ public abstract class BaseService {
protected void closeLogs() {
logger.info(Constants.CONSOLE, "Closing loggers.");

Appender appender = logConfig.getAppender("diag");
Appender appender = logConfig.getAppender("packaged");
if (appender != null && appender.isStarted()) {
appender.stop();
}

logConfig.getRootLogger().removeAppender("File");
logConfig.getRootLogger().removeAppender("packaged");
}

protected void createFileAppender(String logDir, String logFile) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/log4j2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<Loggers>
<Root level="info">
<AppenderRef ref="console" />
<AppenderRef ref="diag" />
<AppenderRef ref="packaged" />
</Root>
</Loggers>
</Configuration>