Skip to content

Update Logstash report to include batch's byte_size p100 and lifetime #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pickypg merged 2 commits into from
Apr 28, 2026
Merged

Update Logstash report to include batch's byte_size p100 and lifetime #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b3a54e
Updates the report generated when taking Logstash diags to include th…
andsel Apr 16, 2026
d87912b
Refactored two almost identival functions to share same code
andsel Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 53 additions & 8 deletions src/main/resources/logstash-diagnostic-templates/flow_metrics.html.ftlh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,27 @@
}
}

const BatchMetricType = Object.freeze({
BYTE_SIZE: 'byte_size',
EVENT_COUNT: 'event_count',
});

/**
* @param {string} pipelineName
* @param {string} metricType One of BatchMetricType.BYTE_SIZE or BatchMetricType.EVENT_COUNT.
*/
const _batchAverageRollingFor = (pipelineName, metricType) => {
try {
const a = data.stats.pipelines[pipelineName].batch[metricType].average;
if (!a) return "N/A";
for (const k of ["last_1_minute", "last_5_minutes", "last_15_minutes"]) {
const v = a[k];
if (v !== null && v !== undefined && v !== "") return v;
}
} catch (e) {}
return "N/A";
}

const createComparisonFormatter = (
analysisWindow,
flow,
Expand Down Expand Up @@ -757,10 +778,9 @@
};
}

const hasBatchP50 = _try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50) !== ""
|| _try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50) !== "";
const hasBatchP90 = _try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90) !== ""
|| _try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90) !== "";
const hasBatchP50 = _try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50) !== "";
const hasBatchP90 = _try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90) !== "";
const hasBatchMax = _try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.max) !== "";

return (
<Stack spacing={2}>
Expand Down Expand Up @@ -865,8 +885,9 @@
<TableCell>Metric</TableCell>
<TableCell align="right">Current</TableCell>
<TableCell align="right">Average</TableCell>
{hasBatchP50 && <TableCell align="center" colSpan={3}>p50</TableCell>}
{hasBatchP90 && <TableCell align="center" colSpan={3}>p90</TableCell>}
{hasBatchP50 && <TableCell align="center" colSpan={4}>p50</TableCell>}
{hasBatchP90 && <TableCell align="center" colSpan={4}>p90</TableCell>}
{hasBatchMax && <TableCell align="center" colSpan={4}>max</TableCell>}
</TableRow>
<TableRow>
<TableCell />
Expand All @@ -876,43 +897,67 @@
<TableCell align="right">1 min</TableCell>
<TableCell align="right">5 min</TableCell>
<TableCell align="right">15 min</TableCell>
<TableCell align="right">Lifetime</TableCell>
</React.Fragment>}
{hasBatchP90 && <React.Fragment>
<TableCell align="right">1 min</TableCell>
<TableCell align="right">5 min</TableCell>
<TableCell align="right">15 min</TableCell>
<TableCell align="right">Lifetime</TableCell>
</React.Fragment>}
{hasBatchMax && <React.Fragment>
<TableCell align="right">1 min</TableCell>
<TableCell align="right">5 min</TableCell>
<TableCell align="right">15 min</TableCell>
<TableCell align="right">Lifetime</TableCell>
</React.Fragment>}
</TableRow>
</TableHead>
<TableBody>
<TableRow>
<TableCell component="th" scope="row">Event count</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.current)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.average.lifetime)}</TableCell>
<TableCell align="right">{_batchAverageRollingFor(selectedPipeline.name, BatchMetricType.EVENT_COUNT)}</TableCell>
{hasBatchP50 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p50.last_15_minutes)}</TableCell>
<TableCell align="right">N/A</TableCell>
</React.Fragment>}
{hasBatchP90 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.event_count.p90.last_15_minutes)}</TableCell>
<TableCell align="right">N/A</TableCell>
</React.Fragment>}
{hasBatchMax && <React.Fragment>
<TableCell align="right">N/A</TableCell>
<TableCell align="right">N/A</TableCell>
<TableCell align="right">N/A</TableCell>
<TableCell align="right">N/A</TableCell>
</React.Fragment>}
</TableRow>
<TableRow>
<TableCell component="th" scope="row">Byte size</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.current)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.average.lifetime)}</TableCell>
<TableCell align="right">{_batchAverageRollingFor(selectedPipeline.name, BatchMetricType.BYTE_SIZE)}</TableCell>
{hasBatchP50 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50.last_15_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p50.lifetime)}</TableCell>
</React.Fragment>}
{hasBatchP90 && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90.last_15_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.p90.lifetime)}</TableCell>
</React.Fragment>}
{hasBatchMax && <React.Fragment>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.max.last_1_minute)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.max.last_5_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.max.last_15_minutes)}</TableCell>
<TableCell align="right">{_try(() => data.stats.pipelines[selectedPipeline.name].batch.byte_size.max.lifetime)}</TableCell>
</React.Fragment>}
</TableRow>
</TableBody>
Expand Down
Loading