-
Notifications
You must be signed in to change notification settings - Fork 1k
Add OHV datacenter #8170 #8178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OHV datacenter #8170 #8178
Conversation
"displayName": "Hillsboro", | ||
"zoneKey": "US", | ||
"lonlat": [45.5225, -122.992], | ||
"region": "North America", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit unclear I'll admit but I'm pretty sure this needs to be:
"region": "North America", | |
"region": "us-hillsboro", |
(this applies to all of them)
The key is made up of the provider + region so the validation functions works properly.
Otherwise I think it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the region
"ovh-us-hillsboro": { | ||
"provider": "ovh", | ||
"displayName": "Hillsboro", | ||
"zoneKey": "US", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zone key should also be more specific and not use a aggregate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Victor meant the zoneKey
that tells Electricity Map the electrical grid region where the data centre is located.
"ovh-bhs": { | ||
"provider": "ovh", | ||
"displayName": "Beauharnois", | ||
"zoneKey": "CA", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"zoneKey": "CA", | |
"zoneKey": "CA-QC", |
"ovh-tor": { | ||
"provider": "ovh", | ||
"displayName": "Toronto", | ||
"zoneKey": "CA", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"zoneKey": "CA", | |
"zoneKey": "CA-ON", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you're right, I hadn't realised it was the zone key of the electricity map, so I've changed it for the countries concerned
"ovh-us-hillsboro": { | ||
"provider": "ovh", | ||
"displayName": "Hillsboro", | ||
"zoneKey": "US", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Victor meant the zoneKey
that tells Electricity Map the electrical grid region where the data centre is located.
}, | ||
"ovh-mum": { | ||
"provider": "ovh", | ||
"displayName": "Mumbai ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx updated
@james I'm a bit bussy with the API changes at the moment so could you maybe take a look at reviewing this one and bring it over the finish line? |
@@ -898,5 +898,145 @@ | |||
"status": "operational", | |||
"source": "https://docs.aws.amazon.com/global-infrastructure/latest/regions/aws-regions.html", | |||
"operationalSince": null | |||
}, | |||
"ovh-hil": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linting error you see in CI is because we expect the ID to match the provider + the region. So we'd expect the key to be ovh-us-hillsbro
and so on for all of the ones you added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I revert back the code to be compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Issue
Add OVH Data center. Request : #8170
Description
Complete the request to add data centres.
OVH is the largest hosting provider in Europe.
More information here :
https://www.ovhcloud.com/fr/datacenters-ovhcloud/
Preview
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.