This repository was archived by the owner on Oct 2, 2020. It is now read-only.
Update HTML compiler to use Pug#34
Open
Xinayder wants to merge 1 commit intoelectron-userland:masterfrom
Xinayder:rockytv
Open
Update HTML compiler to use Pug#34Xinayder wants to merge 1 commit intoelectron-userland:masterfrom Xinayder:rockytv
Xinayder wants to merge 1 commit intoelectron-userland:masterfrom
Xinayder:rockytv
Conversation
The update will allow the compiler to use Pug to compile and render .jade and .pug files.
Contributor
|
Why are we using an alpha version? |
Author
|
It's the latest version available on npm. When I tried installing the
1.11.0 version npm said it couldn't locate it.
Tag history: https://github.com/pugjs/pug/tags
|
Contributor
|
Hm, it might be better to hold off on this until a final version is released |
|
There are also some breaking changes between Jade v1 and Pug v2. |
ghost
mentioned this pull request
|
It's been over a year now, so I suspect that there should be a straight-forward migration path to dropping jade in favor of pug. What needs to be done? Can I help? Should either this PR or #66 be closed in favor of the other or are they truly distinct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update will allow the compiler to use Pug to compile and render .jade and .pug files.
I'm not sure if I've done it correctly, as I couldn't find a way to test the changes. I think that a PR will be required to reflect these changes on electron-compile.