Use correct rx merge import#107
Open
ccnokes wants to merge 2 commits intoelectron-userland:masterfrom
Open
Conversation
|
Is this going to be merged in? Need this fix too. |
partnerinflight
approved these changes
Aug 21, 2018
|
@ccnokes @partnerinflight , I've had this issue as well, but only after transitioning to a new project and setting up electron spellchecker on it for some reason, on an old repo it works perfectly in an old repo for some reason. After applying your patch in this PR manually, I'm still having an issue where, on Windows, spelling errors are not detected, I don't suppose either of you ran into this problem as well? |
|
Nope. Works for me. Except that I keep having to do a yarn install after every yarn upgrade, for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the incorrect rxjs import for
mergeis being used. When using this on Windows, I get aCannot call merge of undefined(or something like that) here https://github.com/ccnokes/electron-spellchecker/blob/6181e409cd62ab1029b54aeceb2ae9375bc27232/src/spell-check-handler.js#L245.The issue is
import 'rxjs/add/operator/merge'addsmergeto the prototype, likeObservable_1.Observable.prototype.merge = merge_1.merge;whereasimport 'rxjs/add/observable/merge';adds it as a static method (which is how it's being used), likeObservable_1.Observable.merge = merge_1.merge;It only occurs on Windows (maybe Linux too, didn't test it though) because
attachToInputbails out early on mac (see https://github.com/ccnokes/electron-spellchecker/blob/6181e409cd62ab1029b54aeceb2ae9375bc27232/src/spell-check-handler.js#L211).I'm not sure how someone else didn't see this by now.... maybe I'm doing something wrong? But this fixes it for me on Windows.