Add ContextMenuBuilder argument for searching using DuckDuckGo instead of Google#138
Open
Powersource wants to merge 2 commits intoelectron-userland:masterfrom
Open
Add ContextMenuBuilder argument for searching using DuckDuckGo instead of Google#138Powersource wants to merge 2 commits intoelectron-userland:masterfrom
Powersource wants to merge 2 commits intoelectron-userland:masterfrom
Conversation
Author
|
So I added this directly in the app instead using the processMenu function here ssbc/patchwork#980 But it would still be cool to have this PR merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this code works since I wasn't able to run the example 😅. And the tests don't all work but they didn't for me even before I started coding hehe. So would be good if someone could try this out before potentially merging :)