You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are the changes I needed to make things work as mentioned in #19, other than the prefix changes I ran into a really weird issue where during the invocation of pyinstaller the which command could not be found, so I did a quick hack to keep everything working.
I tested the output and rpm-ostree installs it fine, though as mentioned in the issue I haven't been able to test the functionality yet.
+ python -m pipenv run pyinstaller arctis-manager.spec
42 INFO: PyInstaller: 6.12.0, contrib hooks: 2025.1
42 INFO: Python: 3.13.3
43 INFO: Platform: Linux-6.14.2-x86_64-with-glibc2.40
43 INFO: Python environment: /home/build/.local/share/virtualenvs/arctis-manager-1.17-build-9po78Wpi
/bin/sh: line 1: which: command not found
Traceback (most recent call last):
File "/home/build/.local/share/virtualenvs/arctis-manager-1.17-build-9po78Wpi/bin/pyinstaller", line 8, in <module>
sys.exit(_console_script_run())
~~~~~~~~~~~~~~~~~~~^^
File "/home/build/.local/share/virtualenvs/arctis-manager-1.17-build-9po78Wpi/lib/python3.13/site-packages/PyInstaller/__main__.py", line 231, in _console_script_run
run()
~~~^^
File "/home/build/.local/share/virtualenvs/arctis-manager-1.17-build-9po78Wpi/lib/python3.13/site-packages/PyInstaller/__main__.py", line 215, in run
run_build(pyi_config, spec_file, **vars(args))
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/build/.local/share/virtualenvs/arctis-manager-1.17-build-9po78Wpi/lib/python3.13/site-packages/PyInstaller/__main__.py", line 70, in run_build
PyInstaller.building.build_main.main(pyi_config, spec_file, **kwargs)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/build/.local/share/virtualenvs/arctis-manager-1.17-build-9po78Wpi/lib/python3.13/site-packages/PyInstaller/building/build_main.py", line 1270, in main
build(specfile, distpath, workpath, clean_build)
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/build/.local/share/virtualenvs/arctis-manager-1.17-build-9po78Wpi/lib/python3.13/site-packages/PyInstaller/building/build_main.py", line 1208, in build
exec(code, spec_namespace)
~~~~^^^^^^^^^^^^^^^^^^^^^^
File "arctis-manager.spec", line 15, in <module>
which_python_p = subprocess.run('which python3', shell=True, check=True, stdout=subprocess.PIPE)
File "/usr/lib64/python3.13/subprocess.py", line 577, in run
raise CalledProcessError(retcode, process.args,
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command 'which python3' returned non-zero exit status 127.
I'm not quite sure that changing from /usr to /usr/local will change something, and not having which recognized is weird.
I think I'm going to study deeper Bazzite and try to sort out an alternative to the current installation (I'd leave /usr/ to official packages only, rather than making it dirt with unofficial ones).
You're right that it doesn't usually make a difference, but Bazzite and other universal blue immutable distros
I'm not quite sure that changing from /usr to /usr/local will change something, and not having which recognized is weird.
I think I'm going to study deeper Bazzite and try to sort out an alternative to the current installation (I'd leave /usr/ to official packages only, rather than making it dirt with unofficial ones).
You're right that it won't change anything for most distros, but Bazzite and universal blue based distros don't expect any "system" packages to install into /usr/local and excludes them from rpm-ostree's functionality because they preserve it across system upgrades. Some details about that are included here https://ostreedev.github.io/ostree/adapting-existing/ and here coreos/fedora-coreos-tracker#1681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes I needed to make things work as mentioned in #19, other than the prefix changes I ran into a really weird issue where during the invocation of
pyinstallerthewhichcommand could not be found, so I did a quick hack to keep everything working.I tested the output and
rpm-ostreeinstalls it fine, though as mentioned in the issue I haven't been able to test the functionality yet.