-
Notifications
You must be signed in to change notification settings - Fork 535
Support for stable MSC3824 #7991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pixlwave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍
|
Ah but will need a changelog of course :) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7991 +/- ##
========================================
Coverage 16.96% 16.97%
========================================
Files 1766 1766
Lines 122112 122110 -2
Branches 49184 49183 -1
========================================
+ Hits 20719 20726 +7
+ Misses 100717 100710 -7
+ Partials 676 674 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Depends on matrix-ios-sdk branch. n.b. this still doesn't implement the SSO redirect parameter as described for MSC3824: > - append action=login and action=register parameters to the SSO redirect URLs
591d67c to
4ea0e5f
Compare
|
I've also included a small fix for the sunset banners in here too (I guess something else changed in the configuration between now and when we tested these against beta.matrix.org). And there's a fix for the UI tests in #7994. |
Depends on matrix-org/matrix-ios-sdk#1917.
Fixes #7925
n.b. this still doesn't implement the SSO redirect parameter as described for MSC3824:
Pull Request Checklist