Conversation
|
@leolost2605 since AppCenter is somewhere you touched recently could I get a review here? I'd like to do some more UI work but I really want to land GTK4 porting first :) |
leolost2605
left a comment
There was a problem hiding this comment.
A few things I noticed during testing, I think most of them aren't blocking though
-
If you've got only a few packages the packages grid in the update view is bottom aligned but I think that's also present in master
-
The backbutton doesn't have the back style applied but I've seen the same thing in settings so I think that's a granite/stylesheet issue?
-
Switching between remotes plays an leaflet animation
-
There are a lot of deprecation warnings but I guess those can be fixed in follow up PRs
Yup that's in master too. Definitely wanna iterate here in a future branch
Ah because widgets are visible by default in GTK4 and we forgot to remove this when we removed the updates recently in another branch. Fixed!
Yeah, pushed a fix to stylesheet 😅
Yeah this might be a leaflet problem 🤔 When we move to NavigationView there's a property there for disabling animations, but I was trying to keep from blowing up the diff. Is this okay to fix in a follow up?
Yeah I was trying to keep the diff here as small as I can |
leolost2605
left a comment
There was a problem hiding this comment.
Seems good enough to iterate on! 🎉
|
Let's fucking goooo |

Fixes #1590
Fixes #1795
Fixes #1940
I've tried to comment all non-obvious changes here. A lot of the diff is just minor API changes. Hide whitespace changes might be useful since there's a few try/catches removed or null or type checks added
Categories:
Application:
closePackage:
StripeDialog:
activates_defaultso use a key controllerprimary_icon_nameso parent a Gtk.ImageMainWindow:
AppInfoView:
AbstractAppContainer: