Application: DRY and reduce nesting on operation finished#2398
Merged
danirabbit merged 4 commits intomainfrom Jan 30, 2026
Merged
Application: DRY and reduce nesting on operation finished#2398danirabbit merged 4 commits intomainfrom
danirabbit merged 4 commits intomainfrom
Conversation
danirabbit
force-pushed
the
danirabbit/application-dryfeedback
branch
from
662aba5 to
c981a66
Compare
jeremypw
approved these changes
Jan 30, 2026
Contributor
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Code makes sense and install/uninstall works as intended afaict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2394