Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
I see the following critical warnings on the terminal: And these warnings are out at src/MainWindow.vala:474 according to gdb: |
Member
Author
|
Sorry, I didn't know about that feature. I went back to using Gtk.Entry and applied CSS instead. |
ryonakano
reviewed
Feb 14, 2025
ryonakano
reviewed
Feb 14, 2025
| @@ -0,0 +1,4 @@ | |||
| entry.flat { | |||
Member
There was a problem hiding this comment.
From #275 (comment):
That's true, but Gtk.Entry has other classes that still show the focus or active border when the input is focused.
This may be due to the following lines? Isn't there any way to just remove the focused style class and avoid re-implementing the entry.flat class here? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixed #275