Get the time format from the new key and make it more efficient#401
Get the time format from the new key and make it more efficient#401
Conversation
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I can't confirm that this works as expected. I always have 12h time in the sidebar no matter what my selection and I always have 24 time in the new event dialog (perhaps a bug in Granite?)
|
Looks like we'd need to use the same logic to set the format here: calendar/src/EventEdition/InfoPanel.vala Lines 276 to 281 in 0087c18 |
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
There seems to be a slight regression with this branch. If the time-format is changed with the calendar open the format of existing events in the agenda does not change both in master and PR. However, in master if calendar is closed and reopened the format changes, but this did not happen with this PR. See screenshot after restarting Calendar (without logging out).
| } | ||
| } | ||
|
|
||
| public string TimeFormat () { |
There was a problem hiding this comment.
You need to change this function name to time_format () in order to resolve the conflict with master
| if (clockformat == null) | ||
| return Granite.DateTime.get_default_time_format (true); | ||
| public bool is_12h { get; private set; default = false; } | ||
| private Greeter.AccountsService? greeter_act = null; |
There was a problem hiding this comment.
Very minor point: I would call this greeter_acc or greeter_acnt` - as "act" is not generally used as an abbreviation for "account" (and is a word in its own right).
| GLib.DBusProxyFlags.GET_INVALIDATED_PROPERTIES); | ||
| is_12h = greeter_act.time_format == "12h" ? true : false; | ||
| } catch (Error e) { | ||
| critical (e.message); |
There was a problem hiding this comment.
Another minor point: Could add an indication that we are falling back to org.gnome.desktop.interface setting to the error message.
|
@tintou Converting to draft as some outstanding issues and conflicts and no recent activity. Please feel free to close or reopen for review after fixing as required. |
4 participants
No description provided.