Clickable links in event descriptions#656
Conversation
| var link_regex = new GLib.Regex ("https?://[\\w.-]*(\\/[\\w-\\d]*)*"); | ||
| comment_link_tag = buffer.create_tag ("link"); | ||
| comment_link_tag.event.connect (on_link_clicked); | ||
| comment_link_tag.set_property ("foreground", "#0000FF"); | ||
| comment_link_tag.underline = Pango.Underline.SINGLE; | ||
| GLib.MatchInfo mi; | ||
|
|
||
| Gtk.TextIter search_iter; | ||
| buffer.get_start_iter (out search_iter); | ||
| if (link_regex.match (buffer.text, 0, out mi)) { | ||
| do { | ||
| int start, end; | ||
| mi.fetch_pos (0, out start, out end); | ||
| var link_text = buffer.text.substring (start, end - start); | ||
|
|
||
| Gtk.TextIter starti, endi; | ||
| search_iter.forward_search (link_text, Gtk.TextSearchFlags.TEXT_ONLY, out starti, out endi, null); | ||
|
|
||
| buffer.apply_tag (comment_link_tag, starti, endi); | ||
| search_iter.forward_chars (link_text.length); | ||
| } while (mi.next ()); | ||
| } |
There was a problem hiding this comment.
I'm not familiar with this so please don't take my comment too seriously. Would it be possible to do the regex search on TextBuffer.changed? I tried your PR and when I type links in, it only adds the tag after I've saved the event and reopened it. Note however that doing a regex search on each TextBuffer.changed would probably be incredibly inefficient but I am of the opinion that event descriptions are typically short and at most contain 100 words or so, so performance shouldn't be too big of a hit.
There was a problem hiding this comment.
I don't think we should assume that descriptions are going to be short, especially the type that have links. Auto-generated Zoom or Webex events have very long descriptions. That said, I'm not sure what the performance hit of regex on change would be.
Two potential compromises I can think of:
- Run the regex when the description field loses focus (so the focus goes somewhere else, like the title). This still wouldn't parse immediately, but it's possible that people could change the description and then go somewhere else, and then they'd see the benefit while they're still editing.
- Use a timeout to wait a second or two after editing stops, then parse. I've seen some work over in elementary/code that worked with this.
|
Thanks for the PR! It seems to work as advertised for me. I haven't taken a very close look at the code, but in the meantime there are a few features that could use some work here:
|
mcclurgm
left a comment
mcclurgm
left a comment
There was a problem hiding this comment.
The regex that you're using isn't quite complete and could use some updating. It misses some common cases. I also noticed when compiling on my machine that there are a few unhandled errors that should be taken care of.
| comment_textview.set_buffer (buffer); | ||
|
|
||
| // Identify links in the description and apply a tag to style them | ||
| var link_regex = new GLib.Regex ("https?://[\\w.-]*(\\/[\\w-\\d]*)*"); |
There was a problem hiding this comment.
This doesn't account for some types of URLs, for example ones that include ? parameters. This is common in things like Zoom links.
Here's a blog post that goes over some example patterns. I'm not sure if there's any licensing issues involved with copying these, however.
| comment_textview.set_buffer (buffer); | ||
|
|
||
| // Identify links in the description and apply a tag to style them | ||
| var link_regex = new GLib.Regex ("https?://[\\w.-]*(\\/[\\w-\\d]*)*"); |
There was a problem hiding this comment.
The compiler also gives a warning of an unhandled GLib.RegexError on this line.
|
|
||
| buffer.apply_tag (comment_link_tag, starti, endi); | ||
| search_iter.forward_chars (link_text.length); | ||
| } while (mi.next ()); |
There was a problem hiding this comment.
The compiler gives a warning of an unhandled GLib.RegexError here.
| iter.forward_to_tag_toggle (tag); | ||
|
|
||
| var link_dst = comment_textview.buffer.get_text (start, iter, false); | ||
| Gtk.show_uri_on_window (null, link_dst, Gdk.CURRENT_TIME); |
There was a problem hiding this comment.
This also has an unhandled error of some sort (the compiler isn't very specific).
|
I'm gonna convert this back to draft since there hasn't been any movement in the last couple weeks. Feel free to mark ready for review once requested changes have been made :) |
|
I'm waiting on the granite update to proceed. As soon as it lands I'll get back to this. |
|
This PR is long stale and has been superseded by another merged PR. I would like to request closing it, to leave more breathing room to actual, relevant PR ? |
6 participants
Fix #571 . Implementation was based on this mailing list message. Requests for improvements are welcome.