Skip to content

AgendaEventRow: create get_timespan_label#915

Merged
danirabbit merged 3 commits intomasterfrom
danirabbit/agendaeventrow-timespanlabelfunc
Feb 5, 2026
Merged

AgendaEventRow: create get_timespan_label#915
danirabbit merged 3 commits intomasterfrom
danirabbit/agendaeventrow-timespanlabelfunc

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 4, 2026

Moves timespan label to its own function

  • Eliminates a bunch of nesting
  • Will be easier to replace name_label and datetime_label with Granite.HeaderLabel in the future

Also:

  • Replace a string comparison with a DateTime.equal
  • Don't use no_show_all etc for hiding/showing which don't exist in Gtk4. Instead simply attach/remove
  • No spaces around en dash for ranges per style guide

@danirabbit danirabbit requested a review from a team February 4, 2026 17:22
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Feb 4, 2026
@danirabbit danirabbit enabled auto-merge (squash) February 5, 2026 19:58
@danirabbit danirabbit merged commit f6bec33 into master Feb 5, 2026
6 checks passed
@danirabbit danirabbit deleted the danirabbit/agendaeventrow-timespanlabelfunc branch February 5, 2026 20:01
@github-project-automation github-project-automation bot moved this from Needs Review to Done in GTK4 Porting Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants