Handle app removal and adding only in appsystem#555
Open
leolost2605 wants to merge 4 commits intomainfrom
Open
Handle app removal and adding only in appsystem#555leolost2605 wants to merge 4 commits intomainfrom
leolost2605 wants to merge 4 commits intomainfrom
Conversation
leolost2605
force-pushed
the
leolost/singleton-apps
branch
from
40d8a87 to
42fcc5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of an app emitting removed and then the appsystem removing it, the app system connects to the app property notifies and then removes it. This now also allows to get apps from the appsystem without adding them to the dock. This will be useful in the future (e.g. appmenu/smart suggestions) to make sure only a single app object exists for an app with a given id. The appsystem will then act kind of like an repository and it connects to the signals and adds them to the dock once they should be in the dock (pinned or has windows).
Includes #553