Skip to content

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jul 26, 2025

Fixes #2623

This issue is rooted in the way the C library handles permanent deletions (which differs from trashing) which makes the handling of file removal notifications in Directory.vala fail as it is based on the (in this case incorrect) assumption that each batch of removed files have the same parent. The C library was sending the same signal for the directory as for its children.

Rather than make substantial changes to the spaghetti that is the C library, I have introduced a separate category of file change for deletion of a folder (only used in the case of permanent deletion). This makes the Directory handle that change separately, which fixes the issue.

This is a long outstanding issue (it occurs at least as far back as v6.4 and probably well before that since the C library is rarely touched).

Since the new function is only called in one place during permanent deletion of a folder, and Directory.vala is not touched, these changes should not impact any other file operation.

@jeremypw jeremypw added this to the 7.1.6 milestone Sep 8, 2025
@jeremypw jeremypw marked this pull request as ready for review September 8, 2025 12:25
@lenemter
Copy link
Member

lenemter commented Oct 5, 2025

Permanently deleting multiple of files/directories at once often doesn't refresh the view

2025-10-05.21-41-48.mp4

@jeremypw jeremypw merged commit c49480a into main Oct 15, 2025
4 checks passed
@jeremypw jeremypw deleted the jeremypw/fix-autorefresh branch October 15, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File Manager does not refresh state of the current path automatically

3 participants