DesktopIntegration: new method to close window used by dock#2202
Open
moises2657 wants to merge 6 commits intoelementary:mainfrom
Open
DesktopIntegration: new method to close window used by dock#2202moises2657 wants to merge 6 commits intoelementary:mainfrom
moises2657 wants to merge 6 commits intoelementary:mainfrom
Conversation
leolost2605
requested changes
Jan 2, 2025
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Hey, thanks for this!
The code looks good only some stylistic nits :)
Most notably you have a lot of empty new lines here which usually only should be used to separate unrelated code, so I think you can remove most of them. Also the linter will probably throw some errors, you can check the workflow for the exact lines and what's wrong there.
leolost2605
reviewed
Jan 2, 2025
|
elementary/dock#278 is about closing an app in background, not just windows, though |
lenemter
reviewed
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of close_window method on Gala.DesktopIntegration to solve the issue: elementary/dock#278
elementary/dock#344