Draft
Conversation
Author
|
I will admit, I'm not familiar with Granite. I'm getting these errors: Click to expand
I presume this is being caused by the Flatpak using the runtime's version...? |
Member
|
Could you tell us the reason why you need this? 🤔 |
Author
|
I discussed it with @danirabbit in private, and she let me know that she's been thinking of doing it, so it's nothing that benefits me really :) |
Member
|
@TheEvilSkeleton yeah this is because those widgets, classes, etc are not released yet in stable Granite. Only in main. So the manifest needs to use Granite from main I suppose @ryonakano it's something I talked about previously with William. It would be nice to be able to test against newer GTK features for the new stylesheet etc as we're developing |
Author
hmm, it's weird that the Demo app seems to fail to build despite using |
This comment was marked as outdated.
This comment was marked as outdated.
ryonakano
reviewed
Jun 12, 2025
Comment on lines
33
to
44
| { | ||
| "name" : "libsass", | ||
| "buildsystem" : "meson", | ||
| "sources" : [ | ||
| { | ||
| "type" : "git", | ||
| "url" : "https://github.com/lazka/libsass.git", | ||
| "branch" : "meson" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name" : "sassc", | ||
| "buildsystem" : "meson", | ||
| "sources" : [ | ||
| { | ||
| "type" : "git", | ||
| "url" : "https://github.com/lazka/sassc.git", | ||
| "branch" : "meson" | ||
| } | ||
| ] | ||
| }, |
Member
There was a problem hiding this comment.
@danirabbit I guess we don't need to install sassc again here if we quit cleaning them up in the SDK manifest. What do you think?
Author
|
@ryonakano could you mark this pull request as draft? I don't remember how we do that on GitHub... It currently doesn't even build due to meson limitations. Someone offered to add some functionality into meson but we'll have to wait for the next version to be released. |
Member
@leonardo-lemos did that. FYI you can do that under the Reviewers section in the right side of PRs: 
@TheEvilSkeleton Could you elaborate on this? What do you mean with "the meson limitations"? And which PR did add the "some functionality" in https://github.com/mesonbuild/meson? |
Author
Thanks!
mesonbuild/meson#14782 - I accidentally mentioned PR rather than "an unpushed commit from someone else's system" 😅 |
This is needed to use the repo's generated library, rather than the system's.
Author
|
Just to reiterate: at the time of writing this, this PR won't work on the latest stable version of meson; only on mesonbuild/meson#14782. You can install and run that version with: $ pip install git+https://github.com/dcbaker/meson@submit/vala-header-method
$ meson setup --reconfigure _build
$ meson compile -C _build/
$ ./_build/demo/granite-7-demo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.