Skip to content

ScreenCast/Dialog: check when row activated#170

Merged
danirabbit merged 6 commits intomainfrom
danirabbit/screencast-selectonrowclick
Jan 31, 2026
Merged

ScreenCast/Dialog: check when row activated#170
danirabbit merged 6 commits intomainfrom
danirabbit/screencast-selectonrowclick

Conversation

@danirabbit
Copy link
Member

Fixes #165

@danirabbit danirabbit requested a review from a team January 29, 2026 00:32
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Jan 29, 2026
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just put the content i.e. image and label_box in another box and make that a child of the button? Or does that mess with some styling?

@danirabbit danirabbit removed this from OS 8.1.1 Jan 30, 2026
@danirabbit
Copy link
Member Author

@leolost2605 nope works perfectly, great suggestion!

@danirabbit danirabbit enabled auto-merge (squash) January 31, 2026 15:58
@danirabbit danirabbit merged commit 1d5dabc into main Jan 31, 2026
4 checks passed
@danirabbit danirabbit deleted the danirabbit/screencast-selectonrowclick branch January 31, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Radio button label not activable in screen sharing selector

2 participants