Skip to content

Add choice of destination to notification workflow #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeremypw wants to merge 2 commits into
base: notification-workflow
Choose a base branch
from
+31 −2
Draft

Add choice of destination to notification workflow #262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c338041
Add choice of destination
Apr 12, 2023
929f409
Merge branch 'notification-workflow' into choose-destination
danirabbit Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions src/ScreenshotWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* Copyright 2017–2020 elementary, Inc. (https://elementary.io)
* 2014–2016 Fabio Zaramella <ffabio.96.x@gmail.com>
*
Expand All @@ -18,7 +18,7 @@
*/

public class Screenshot.ScreenshotWindow : Hdy.ApplicationWindow {
public bool to_clipboard { get; construct; }
public bool to_clipboard { get; set construct; }
public bool mouse_pointer { get; set; }
public bool redact { get; set; }

Expand Down Expand Up @@ -109,6 +109,22 @@ public class Screenshot.ScreenshotWindow : Hdy.ApplicationWindow {

var delay_spin = new Gtk.SpinButton.with_range (0, 15, 1);

var destination_label = new Gtk.Label (_("Send to:")) {
halign = Gtk.Align.END,
valign = Gtk.Align.CENTER,
};

var dest_screenshots_button = new Gtk.RadioButton (null) {
tooltip_text = _("Save to Screenshots"),
image = new Gtk.Image.from_icon_name ("document-save", Gtk.IconSize.DND)
};

//TODO Better icon
var dest_clipboard_button = new Gtk.RadioButton.from_widget (dest_screenshots_button) {
tooltip_text = _("Save to Clipboard"),
image = new Gtk.Image.from_icon_name ("edit-paste", Gtk.IconSize.DND)
};

var take_btn = new Gtk.Button.with_label (_("Take Screenshot"));
take_btn.get_style_context ().add_class (Gtk.STYLE_CLASS_SUGGESTED_ACTION);
take_btn.can_default = true;
Expand Down Expand Up @@ -136,6 +152,10 @@ public class Screenshot.ScreenshotWindow : Hdy.ApplicationWindow {
option_grid.attach (delay_label, 0, 3);
option_grid.attach (delay_spin, 1, 3);

option_grid.attach (destination_label, 0, 4);
option_grid.attach (dest_screenshots_button, 1, 4);
option_grid.attach (dest_clipboard_button, 2, 4);

var actions = new Gtk.ButtonBox (Gtk.Orientation.HORIZONTAL) {
layout_style = Gtk.ButtonBoxStyle.END,
spacing = 6
Expand Down Expand Up @@ -208,6 +228,10 @@ public class Screenshot.ScreenshotWindow : Hdy.ApplicationWindow {
destroy ();
});

dest_clipboard_button.toggled.connect (() => {
to_clipboard = dest_clipboard_button.active;
});

var gtk_settings = Gtk.Settings.get_default ();
gtk_settings.notify["gtk-application-prefer-dark-theme"].connect (() => {
update_icons (gtk_settings.gtk_application_prefer_dark_theme);
Expand Down Expand Up @@ -285,6 +309,11 @@ public class Screenshot.ScreenshotWindow : Hdy.ApplicationWindow {
private void save_pixbuf (Gdk.Pixbuf screenshot) {
if (to_clipboard) {
Gtk.Clipboard.get_default (this.get_display ()).set_image (screenshot);
var notification = new Notification (_("Screenshot copied to clipboard"));
notification.set_icon (new ThemedIcon ("edit-paste"));
notification.set_priority (NotificationPriority.LOW);

GLib.Application.get_default ().send_notification (null, notification);
} else {
try {
save_file (screenshot);
Expand Down