Skip to content

SaveDialog: use fileinfo, localize, DRY#269

Merged
jeremypw merged 3 commits intomasterfrom
danirabbit/filechooser-followup
Aug 30, 2023
Merged

SaveDialog: use fileinfo, localize, DRY#269
jeremypw merged 3 commits intomasterfrom
danirabbit/filechooser-followup

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Aug 29, 2023

Follow up to #243

  • DRY updating location button
  • Use the ellipsis icon and add some spacing
  • Use build in translation for Cancel button, translate Select button
  • Use FileInfo to get icon and display name for path

@danirabbit danirabbit requested a review from a team August 29, 2023 21:42
jeremypw
jeremypw approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected.

@jeremypw jeremypw merged commit aeff9f6 into master Aug 30, 2023
@jeremypw jeremypw deleted the danirabbit/filechooser-followup branch August 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danirabbit @jeremypw