Conversation
65bbebe to
cf506d6
Compare
|
@lenemter I'm not quite sure what you're saying. Right now there is the gnome enable animations key that both we and gnome use to completely disable animations. This is useful for performance e.g. in a VM but was misused as an accessibility setting. Therefore recently gnome introduced along with the free desktop portal spec a new key for reduce animation i.e. to keep some animations or alter them so that they are not straining or irritating for more people. They added a new key to their gsettings (https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/merge_requests/114) I'm not sure is that the key they you meant we should use? if so I agree that's a possibility but I think since the implementation is private to GNOME we should probably use our own key instead of relying on theirs. If you mean we should continue using the old enable animations key I disagree since these are separate things (performance vs accessibility). This of course means we should switch the settings toggle for reduce motion to this new key and maybe migrate existing users. |
|
@lenemter can I get you to follow up here please? :) |

See https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/236 and flatpak/xdg-desktop-portal#1840
This PR also fixes read_all not including the other freedesktop appearance values, i.e. accent color and prefers color scheme.