WallpaperContainer: set uri, all the context menu controllers#478
Merged
danirabbit merged 2 commits intomainfrom Jan 28, 2026
Merged
WallpaperContainer: set uri, all the context menu controllers#478danirabbit merged 2 commits intomainfrom
danirabbit merged 2 commits intomainfrom
Conversation
leonardo-lemos
approved these changes
Jan 16, 2026
Collaborator
|
Just wondering whether it is possible to provide the Granite context menu stuff as an interface rather than tied to ListItem in order to avoid copying code? |
Member
Author
|
@jeremypw yeah I agree I'd like to do that in the future if possible. Probably I'll make like a Granite.GridItem or add a menu_model property to another widget and that'll be the opportunity to abstract it and make that abstraction public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes uri settable which we need for recycling widgets in #470
While we're here, copy the context menu code from elementary/granite#826 so we can activate the menu with keyboard button, long press on touch, etc