Make organisation upgradeable by coding to an interface#5
Open
nrchandan wants to merge 1 commit intoelenadimitrova:masterfrom
Open
Make organisation upgradeable by coding to an interface#5nrchandan wants to merge 1 commit intoelenadimitrova:masterfrom
nrchandan wants to merge 1 commit intoelenadimitrova:masterfrom
Conversation
Contributor
Author
|
Addresses issue #4 |
Contributor
Author
|
Will push this again after rebasing with the latest master. |
Owner
|
Yes, indeed interfaces are the right way to abstract hard-linked contracts (i.e. contracts imported in other contracts and therefore wired in their upgrade) and this is a simple implementation of it, however the full model is a factory pattern we use that I thought a little overly complex to demonstrate in the article, see #4 (comment) |
The Parent contract is now coded to an Organisation interface rather than its implementation. This enables upgrading of the Organisation contract as long as the ABI doesn't change. This also implies that Parent can no longer create Organisations. In this implementation, Organisation needs to be instantiated by the user and passed on to the Parent contract for registering or upgrading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Parent contract is now coded to an Organisation interface
rather than its implementation. This enables upgrading of the
Organisation contract as long as the ABI doesn't change. This also
implies that Parent can no longer create Organisations. In this
implementation, Organisation needs to be instantiated by the user
and passed on to the Parent contract for registering or upgrading.