Skip to content

Conversation

@trea
Copy link

@trea trea commented Oct 14, 2017

Hello!

Thanks for your work on this package!

This PR drops references to the DB facade. I ran into an issue with this on a Lumen project that doesn't use Facades where there was a "Class 'DB' not found" exception thrown. I noticed that the methods being called are actually on the Connection, so I opted to use the instance of the Connection that the model has access to anyway, rather than calling the DB facade. 😄

Thanks!

@desh901
Copy link

desh901 commented Nov 7, 2017

Sorry for the late response! Thanks for the PR, i totally get what you mean since i encountered similar problems when using Laravel packages within Lumen. We will test this out and eventually merge the PR, but it should be ok out of the box since the mod is clear and simple.

@trea
Copy link
Author

trea commented Nov 7, 2017

You're welcome! No problem on the response time, appreciate you taking the time to look at the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants