Skip to content

fixed bugs in table.scan with 'limit' and row keys that cannot be UTF-8 encoded#4

Open
osboo wants to merge 7 commits intoeliangcs:masterfrom
osboo:master
Open

fixed bugs in table.scan with 'limit' and row keys that cannot be UTF-8 encoded#4
osboo wants to merge 7 commits intoeliangcs:masterfrom
osboo:master

Conversation

@osboo
Copy link
Copy Markdown

@osboo osboo commented May 10, 2018

Hi, could you please consider merging this into master:

  • limit flag in table.scan now works correctly (bug with sign fixed)
  • row_prefix flag now can be arbitrary binary string which is the case for MD5 generated row keys. These keys cannot be UTF-8 encoded which made testing such database usage impossible. To fix this latest functionality from happybase was taken.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 99.683% when pulling f0ff2c2 on osboo:master into e5d77f8 on eliangcs:master.

@coveralls
Copy link
Copy Markdown

coveralls commented May 10, 2018

Coverage Status

Coverage decreased (-2.4%) to 96.933% when pulling a24957f on osboo:master into e5d77f8 on eliangcs:master.

@osboo
Copy link
Copy Markdown
Author

osboo commented May 12, 2018

hi @eliangcs!
Hope you have time to include this PR with bug fixes to the main line. We already use it in our projects. Might make others' life easier:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants