chore: initial ci jobs#3
Merged
Lauri "datafox" Heino (melodicore) merged 1 commit intomainfrom Jun 7, 2025
Merged
Conversation
chore: add build job chore: add pr job hook chore: add push job hook Signed-off-by: Sam Gammon <sam@elide.dev>
There was a problem hiding this comment.
Pull Request Overview
Adds initial CI workflows for push and pull request events by introducing two trigger files and a reusable build workflow.
- Introduce
on.push.ymlto trigger CI on pushes tomain - Introduce
on.pr.ymlto trigger CI on all pull requests - Add
job.build.ymlas a reusable build workflow with Maven and Gradle steps
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/on.push.yml | Defines push trigger for main to call the build job |
| .github/workflows/on.pr.yml | Defines PR trigger to call the build job |
| .github/workflows/job.build.yml | Implements reusable build workflow steps |
Comments suppressed due to low confidence (1)
.github/workflows/on.push.yml:1
- [nitpick] Consider renaming this file to
on-push.yml(andon.pr.ymltoon-pr.yml) to align with common GitHub Actions naming conventions and avoid confusion with the file extension.
.github/workflows/on.push.yml
Comment on lines
+1
to
+19
| name: "CI" | ||
|
|
||
| "on": | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: "read" | ||
|
|
||
| jobs: | ||
| build: | ||
| name: "Build" | ||
| uses: ./.github/workflows/job.build.yml | ||
| secrets: inherit | ||
| permissions: | ||
| contents: "read" | ||
| with: | ||
| runner: "ubuntu-latest" |
There was a problem hiding this comment.
[nitpick] Remove unnecessary double quotes around static values (e.g., name: CI) and keys to improve YAML readability and consistency.
Suggested change
| name: "CI" | |
| "on": | |
| push: | |
| branches: | |
| - main | |
| permissions: | |
| contents: "read" | |
| jobs: | |
| build: | |
| name: "Build" | |
| uses: ./.github/workflows/job.build.yml | |
| secrets: inherit | |
| permissions: | |
| contents: "read" | |
| with: | |
| runner: "ubuntu-latest" | |
| name: CI | |
| on: | |
| push: | |
| branches: | |
| - main | |
| permissions: | |
| contents: read | |
| jobs: | |
| build: | |
| name: Build | |
| uses: ./.github/workflows/job.build.yml | |
| secrets: inherit | |
| permissions: | |
| contents: read | |
| with: | |
| runner: ubuntu-latest |
| jobs: | ||
| build: | ||
| name: "Maven Plugin" | ||
| runs-on: ${{ inputs.runner || 'ubuntu-latest' }} |
There was a problem hiding this comment.
Since runner has a default value in the workflow_call inputs, you can simplify this to runs-on: ${{ inputs.runner }} without the fallback.
Suggested change
| runs-on: ${{ inputs.runner || 'ubuntu-latest' }} | |
| runs-on: ${{ inputs.runner }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds initial CI jobs on-push and on-PR.
Changelog