Conversation
- Add new GitHub workflow for automated OpenCV CUDA builds - Create updated build script based on documentation improvements - Update entrypoint script with fallback mechanism - Add comprehensive documentation - Maintain backward compatibility with existing systems - Generate artifacts for easy distribution - Include verification and error handling Based on super-resolution work and updated build practices from comfystream-docs technical documentation.
- Replace inline workflow scripting with Dockerfile approach - Use livepeer/comfyui-base as foundation image for consistency - Split build process into modular, maintainable scripts: - opencv-cuda-deps.sh: dependency installation - opencv-build.sh: core compilation logic - opencv-package.sh: artifact creation with install script - Improve maintainability by separating concerns - Add comprehensive artifact packaging with checksums - Update documentation to reflect new architecture - Optimize Docker layers for faster rebuilds
The GitHub App doesn't have workflow permissions, so temporarily moving the workflow file. It can be added manually via GitHub UI.
- Deleted Dockerfile, build scripts, dependency installation script, packaging script, and related documentation for OpenCV CUDA. - This cleanup is part of the transition to a new modular build system with improved GitHub workflows.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 55 55
=========================================
Hits 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.